Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add domain_whitelist.kv3 #101

Merged
merged 1 commit into from
Sep 18, 2023
Merged

feat: add domain_whitelist.kv3 #101

merged 1 commit into from
Sep 18, 2023

Conversation

craftablescience
Copy link
Contributor

@craftablescience craftablescience commented Sep 17, 2023 •
edited
Loading

Ties in to internal MR adding a whitelist to AsyncWebRequest, fine to merge after that MR is in
Internal MR has been merged, this should be merged before your next release

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

tsa96
tsa96 approved these changes Sep 18, 2023
View reviewed changes
domain_whitelist.kv3 Outdated Show resolved Hide resolved
tsa96
tsa96 requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to Steam URLs IMO

Gocnak
Gocnak approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@Gocnak Gocnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do all API requests in c++ code so this is fine

@Gocnak Gocnak merged commit 2d85c3d into momentum-mod:master Sep 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsa96 tsa96 tsa96 approved these changes

@Gocnak Gocnak Gocnak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craftablescience @Gocnak @tsa96